Comments on: Format a time interval with the requested granularity http://blog.fedecarg.com/2009/06/25/format-a-time-interval-with-the-requested-granularity/ Simple is better than complex. Complex is better than complicated. | @fedecarg Mon, 08 Mar 2010 06:09:25 +0000 http://wordpress.com/ hourly 1 By: Federico http://blog.fedecarg.com/2009/06/25/format-a-time-interval-with-the-requested-granularity/#comment-4400 Federico Mon, 29 Jun 2009 18:26:00 +0000 http://blog.fedecarg.com/?p=1691#comment-4400 Indeed, a year may contain one or more extra days. I guess for those who want more precision, then yes, it is important to take the leap year into consideration. Thanks. Indeed, a year may contain one or more extra days. I guess for those who want more precision, then yes, it is important to take the leap year into consideration.

Thanks.

]]> By: Gerard Klomp http://blog.fedecarg.com/2009/06/25/format-a-time-interval-with-the-requested-granularity/#comment-4396 Gerard Klomp Mon, 29 Jun 2009 11:15:48 +0000 http://blog.fedecarg.com/?p=1691#comment-4396 I really liked the idea you had, but for my purpose I had to change your class a bit. The first thing I changed was added support for PHP DateTime, including DateTimeZone so that the current date is compared correctly, I also changed the method so that a string with the current date can be passed (as Nzsz already mentioned). The second thing I changed was the support for leap years. Currently your class does not support those years and will generate an incorrect day/.. count for years < 2008. The other stuff is mostly for viewing pleasure, and to replace the names used. http://www.pastebin.be/19456 I really liked the idea you had, but for my purpose I had to change your class a bit. The first thing I changed was added support for PHP DateTime, including DateTimeZone so that the current date is compared correctly, I also changed the method so that a string with the current date can be passed (as Nzsz already mentioned).

The second thing I changed was the support for leap years. Currently your class does not support those years and will generate an incorrect day/.. count for years < 2008.

The other stuff is mostly for viewing pleasure, and to replace the names used.

http://www.pastebin.be/19456

]]> By: Nzsz http://blog.fedecarg.com/2009/06/25/format-a-time-interval-with-the-requested-granularity/#comment-4395 Nzsz Sun, 28 Jun 2009 20:38:53 +0000 http://blog.fedecarg.com/?p=1691#comment-4395 You should do something with the explode('|', $key) because it will done every time the function is called => If i call it 10 times the explode will be called 10 times per unit => 60 times! (perhaps hardcoded as a static array of class or function Also I would prefer the use of a static method, that would also speed the class up and last but not least i think i would prefer the strtotime-function inside of the getInterval-function so i don't have to call it every time and save some annoying tipping ;) You should do something with the explode(‘|’, $key) because it will done every time the function is called => If i call it 10 times the explode will be called 10 times per unit => 60 times! (perhaps hardcoded as a static array of class or function

Also I would prefer the use of a static method, that would also speed the class up

and last but not least i think i would prefer the strtotime-function inside of the getInterval-function so i don’t have to call it every time and save some annoying tipping ;)

]]> By: DreamNest http://blog.fedecarg.com/2009/06/25/format-a-time-interval-with-the-requested-granularity/#comment-4388 DreamNest Fri, 26 Jun 2009 13:31:17 +0000 http://blog.fedecarg.com/?p=1691#comment-4388 [...] Cargnelutti has posted a class (DateIntervalFormat) that gives you the difference between a date and “now” in words [...] [...] Cargnelutti has posted a class (DateIntervalFormat) that gives you the difference between a date and “now” in words [...]

]]> By: Federico http://blog.fedecarg.com/2009/06/25/format-a-time-interval-with-the-requested-granularity/#comment-4385 Federico Thu, 25 Jun 2009 22:43:15 +0000 http://blog.fedecarg.com/?p=1691#comment-4385 Static? Why? Static? Why?

]]> By: BigTrucK http://blog.fedecarg.com/2009/06/25/format-a-time-interval-with-the-requested-granularity/#comment-4384 BigTrucK Thu, 25 Jun 2009 20:46:05 +0000 http://blog.fedecarg.com/?p=1691#comment-4384 Nice. Although I would have made the function static. Nice. Although I would have made the function static.

]]> By: Webs Developer http://blog.fedecarg.com/2009/06/25/format-a-time-interval-with-the-requested-granularity/#comment-4383 Webs Developer Thu, 25 Jun 2009 18:03:15 +0000 http://blog.fedecarg.com/?p=1691#comment-4383 [...] Cargnelutti has posted a class (DateIntervalFormat) that gives you the difference between a date and “now” in words [...] [...] Cargnelutti has posted a class (DateIntervalFormat) that gives you the difference between a date and “now” in words [...]

]]> By: Jasper http://blog.fedecarg.com/2009/06/25/format-a-time-interval-with-the-requested-granularity/#comment-4381 Jasper Thu, 25 Jun 2009 07:26:52 +0000 http://blog.fedecarg.com/?p=1691#comment-4381 Cool. I wrote something similar to this a couple of weeks ago. The only differences being that the words for "day", "month", "year" etc were set as class properties so you could set externally and you could also set the date that you're using as time() so you could measure betweek 2 specific dates if you wanted to. I'd like to implement something for MySQL timestamps as well - I don't really trust unix ones. Cool. I wrote something similar to this a couple of weeks ago. The only differences being that the words for “day”, “month”, “year” etc were set as class properties so you could set externally and you could also set the date that you’re using as time() so you could measure betweek 2 specific dates if you wanted to.

I’d like to implement something for MySQL timestamps as well – I don’t really trust unix ones.

]]>